https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5755
Fulko Hew <fulko.hew@xxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #6022|review_for_checkin? |
Flag| |
Attachment #6022|0 |1
is obsolete| |
Attachment #6024| |review_for_checkin?
Flag| |
--- Comment #3 from Fulko Hew <fulko.hew@xxxxxxxxx> 2011-03-16 06:28:00 PDT ---
Created an attachment (id=6024)
--> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=6024)
'Corrected' alternate patch with normal handling of FT_UINT_STRING.
The original alternate patch did not maintain intra-packet offset correctly, it
trimmed a little too much off of the old code, hence this correction.
Although this corrected alternate patch does work, it looses the discrimination
between the length, and the string itself. After developing an AgentX support
library, I found this additional information (break-out) useful, the
FT_UINT_STRING technique requires the user to 'understand' that they are
looking at a 4-byte-length encoded something, whereas the old approach provided
that additional clue.
Although I understand the issue of not-requiring the additional allocation, the
older presentation was more useful. I would prefer the original
presentation/patch.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
