https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5048
Guy Harris <guy@xxxxxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #4957|review_for_checkin? |review_for_checkin-
Flag| |
--- Comment #3 from Guy Harris <guy@xxxxxxxxxxxx> 2010-07-23 15:09:21 PDT ---
(From update of attachment 4957)
The patch adds some new column types; could those be done instead as custom
columns, using a named field?
The capture_ routines are only used for link-layer types that exist in pcap and
pcap-ng files, as those are the only link-layer types supported when capturing
(as Wireshark uses libpcap/WinPcap for capturing). Unless you've added those
to libpcap (which means asking tcpdump.org for link-layer types), there's no
need for capture_ routines for the new encapsulation types.
The introductory comment from packet-ethernettap.c should match
packet-ethernettap.c - it currently claims it's packet-ethertype.c and credits
Gilbert Ramirez.
The same applies to packet-vw-radiotap.c. Also, you should probably replace
RADIOTAP with VW_RADIOTAP in the enum members, to make it clear that those
presence bits are in a separate space from the presence bits in standard
radiotap headers.
The "various internal variables" in the .vwr reader file should not be static;
we make no guarantee that Wiretap will only have one file open. Instead, you
should allocate a private data structure for each wtap structure, and attach it
to that structure through the "priv" pointer.
Is there any need to have separate Wiretap file types based only on the FPGA
version?
Instead of defining your own data types in vwr.h, use the GLib types, e.g.
guint8 for 8-bit unsigned integers, guint16 for 16-bit unsigned integers,
guint32 for 32-bit unsigned integers, and guint64 for 64-bit unsigned integers.
Use G_GINT64_CONSTANT() to make constants that have a 64-bit type - e.g.,
G_GINT64_CONSTANT(1000000000000) for a signed constant and
G_GINT64_CONSTANT(1000000000000U) for an unsigned constant.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
