https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3787
kahou <kahou82@xxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kahou82@xxxxxxxxx
--- Comment #3 from kahou <kahou82@xxxxxxxxx> 2009-07-31 12:07:55 PDT ---
(In reply to comment #1)
> Please update the text in the header comment block to match the real situation.
>
> Don't call FC dissector only if tree!=NULL, it must always be called.
>
> Shouldn't you set pinfo->sof_eof, just as fcoe does?
>
> Shouldn't this fcsof dissector be integrated into the fc dissector?
>
I updated comments and pass to fc dissector no matter what.
I also populate pinfo->sof_eof according to delimiters.
The reason that I cannot integrate this in fc dissector is that other fc
dissectors (such as fcoe) use fc dissector. The delimiter of FCOE only have 2
bytes while native fc delimiters have 4 bytes.
Beside this, FC without delimiter has another DLT type (224).
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
