https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3325
Anders Broman <anders.broman@xxxxxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |anders.broman@xxxxxxxxxxxx
--- Comment #4 from Anders Broman <anders.broman@xxxxxxxxxxxx> 2009-03-17 23:44:57 PDT ---
Hi,
Just some small comment it's probably better to get the dissector handles
in the register routine rather than doing:
call_dissector( find_dissector("pw_fr"), next_tvb, pinfo, tree);
for every packet.
e.g
- call_dissector( find_dissector("pw_fr"), next_tvb, pinfo, tree);
+ call_dissector( pw_fr_handle, next_tvb, pinfo, tree);
Why do:
fecn_bit = ( tvb_get_guint8(tvb, 0) & 0x8 ) >> 3;
:
proto_tree_add_uint( tr, hf_pw_fr_cw_fecn, tvb, 0, 1, fecn_bit );
Instead of
proto_tree_add_item( tr, hf_pw_fr_cw_fecn, tvb, 0, 1, FALSE );
:
&hf_pw_fr_cw_fecn,
{
"FECN bit", "pwfr.fecn", FT_UINT8, BASE_DEC, NULL,
0x08,
"FECN bit", HFILL
}
Regards
Anders
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
