Wireshark-bugs: [Wireshark-bugs] [Bug 3294] New: MPLS payload dissection: +menu for default, ~pw-eth, ~pw-generic

From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 2 Mar 2009 02:53:00 -0800 (PST)

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3294

           Summary: MPLS payload dissection: +menu for default, ~pw-eth,
                    ~pw-generic
           Product: Wireshark
           Version: 1.1.x (Experimental)
          Platform: PC
        OS/Version: Windows XP
            Status: NEW
          Severity: Major
          Priority: Medium
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: artem.tamazov@xxxxxxxxxxx



Artem Tamazov <artem.tamazov@xxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2796|                            |review_for_checkin?
               Flag|                            |


Created an attachment (id=2796)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=2796)
MPLS payload dissection: +menu for default, ~pw-eth, ~pw-generic

Build Information:
TShark 1.1.3-tlab-pwe3-common (SVN Rev unknown)

Copyright 1998-2009 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled with GLib 2.18.4, with WinPcap (version unknown), with libz 1.2.3,
without POSIX capabilities, with libpcre 7.0, with SMI 0.4.8, with c-ares
1.6.0,
without Lua, with GnuTLS 2.6.4, with Gcrypt 1.4.4, with MIT Kerberos, with
GeoIP.

Running on Windows XP Service Pack 2, build 2600, with WinPcap version 4.0.2
(packet.dll version 4.0.0.1040), based on libpcap version 0.9.5, GnuTLS 2.6.4,
Gcrypt 1.4.4.

Built using Microsoft Visual C++ 7.10 build 3077
--
The changes below allow future development of dissectors for MPLS payloads.

Added: Selection of default decoding mode for MPLS payloads.
Available in Edit/Preferences/Protocols/MPLS.
Previously, ethernet-only autoguessing logic was hardwired as default.

Added: Dedicated Ethernet PW auto-guessing (heuristic) dissection.

Modified: Generic/Preferred MPLS PW dissection:
* Now it uses raw data dissector instead of eth_withoutfs (finally, it is
generic!).
* Now it properly supports IPv4, IPv6, PWACH decode.

Modified: Ethernet PW auto-guessing dissection logic.
* It has been moved to appropriate file.
* Now it first looks is data like plain ethertnet, and if so, 
  decodes data as Ethernet PW without CW;
  otherwise it tries to decode data as Ethernet PW with CW
  (which includes also checking for IPv4/IPv6/PWACH data).
  Before this mod, the order of guessing was almost vise versa.

Modified: Names of Ethernet PW dissectors were changed a bit
in order to make them more clear and uniform.

Fuzz-tested.
SVN baseline is 27576.


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.