https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2971
--- Comment #24 from Anders Broman <anders.broman@xxxxxxxxxxxx> 2008-11-12 09:52:45 PDT ---
Hi,
I've checked the patch in with some changes:
- // is not allowed in comments ( try checkapi as a make target).
- I think shift is faster than * ( I may be misstaken). *8 -> <<3
- Used current_offset to be in style with the rest of the code.
- We normaly prefix value_strings with the protocol name and sufix with _vals
- I removed _add_uint when there seemed to be no need to get the actual value.
( add_item) can be used on octet aligned bit values, just use a bit mask.
- removed some unused value_strings and one hf_var
Question: Some of the IE's like "3.2.2.67 LCS Client Type" actually
belongs in bssmap_le and should be "called" from bssmap insted, right?
Regards
Anders
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
