Wireshark · Ethereal-dev: [Ethereal-dev] packet-smpp.c - disregard previous patch

[Biot Olivier <Olivier.Biot@xxxxxxxxxxx>]

Hi all,

[Please disregard my previous patch]

Attached new patch adds support for the GSM SMS and the GSM Cell Broadcast
Service (CBS) data coding scheme (DCS) as per 3GPP TS 23.038 V5.0.0. As it
is very difficult to know which Data Coding Scheme is applicable, I always
render the 3 possibilities (SMPP, GSM SMS, GSM CBS).
This patch also corrects the SMS reassembly code which now works, and it
also adds support for two more UDH Information Elements.
Finally, some fields based on a text string did not show up when the string
was empty, so the default value was not shown. This has been fixed for the
SMPP parameters  shedule_delivery_time, validity_time and service_type.

Please review and check in.

Regards,

Olivier

PS I'm using 4-space tabulation.

Attachment: packet-smpp.c.diff
Description: Binary data