Wireshark · Ethereal-dev: Re: [Ethereal-dev] Updated enip dissector

[Guy Harris <guy@xxxxxxxxxxxx>]

On Thursday, August 7, 2003, at 2:38 PM, Joakim Wiberg wrote:

> This patch solves some minor issues that in packet-enip.c.

1) The patch was a "reverse order" patch, with the first version being 
the newer version, which causes patch to warn that the it might be 
reversed and to ask you if you want to assume "-R".

2) The RCS ID goes backwards if you apply it with "-R".

3) "add_cip_data()" should be static.

4) It gives some unused variable warnings with GCC 3.3:

packet-enip.c:1213: warning: unused variable `mr_data_item'
packet-enip.c:1222: warning: unused variable `uncon_add_stat_size'

(line numbers may differ).