ANNOUNCEMENT: Live Wireshark University & Allegro Packets online APAC Wireshark Training Session
July 17th, 2024 | 10:00am-11:55am SGT (UTC+8) | Online

Ethereal-dev: Re: [Ethereal-dev] [PATCH] BGP Route-Refresh message

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Guy Harris <guy@xxxxxxxxxx>
Date: Wed, 16 May 2001 11:54:48 -0700 (PDT)
> Attached is the patch for dealing with Cisco's own Route-Refresh 
> message type. New Cisco routers sends out two capabilities, one is 
> cap code 2 as required in RFC2918, the one is cap code 0x80 as 
> defined by Cisco (used in old 3600 routers).

Checked in.  (You're currenly credited only as <bgp4news@xxxxxxxxx>, as
there was no name in the message.)

Note that, in some places, some piece of mail software (Yahoo! Mail?)
"helpfully" line-wrapped some of the lines in your patch, e.g.:

> Index: packet-bgp.c
> ===================================================================
> RCS file: /cvsroot/ethereal/packet-bgp.c,v
> retrieving revision 1.35
> diff -u -r1.35 packet-bgp.c
> --- packet-bgp.c	2001/04/23 18:19:02	1.35
> +++ packet-bgp.c	2001/05/16 04:02:36

> @@ -401,6 +402,7 @@
>                          p++;
>                      }
>                      break;
> +                case BGP_CAPABILITY_ROUTE_REFRESH_CISCO:
>                  case BGP_CAPABILITY_ROUTE_REFRESH:
>                      ti = proto_tree_add_text(subtree, tvb, p - 4, 
>                           2 + plen, "Route refresh capability (%u %
> s)", 2 + plen,

I was able to put things back the way they were supposed to be, but you
might want to send future patches as attachments, if possible, in the
hopes that the mail system won't line-wrap them.