Wireshark · Wireshark-dev: Re: [Wireshark-dev] Lua minimum version

[Dario Lombardo <lomato@xxxxxxxxx>]

Thanks, I figured it out myself. Just for the sake of completeness, I was working on the fix, but I was beaten by (the almost identical patch by) Gerald in 

commit 060811713fa63e04cbed95af4e7720794a1bf3a6

Author: Gerald Combs <gerald@xxxxxxxxxxxxx>

Date:   Tue Dec 18 08:30:27 2018 -0800

    Lua: Fix compilation with Lua 5.1.

On Wed, Dec 19, 2018 at 11:05 PM Peter Wu <peter@xxxxxxxxxxxxx> wrote:

On Wed, Dec 19, 2018 at 09:53:48AM +0100, Dario Lombardo wrote:
> Hi,
> which is the lua minimum version supported?

CMake says:
 * LUA (required version >= 5.1)


> The commit
>
> commit 5953756305388724545f0df46d286be2f02c048a
> Author: Guy Harris <guy@xxxxxxxxxxxx>
> Date:   Mon Dec 17 10:57:20 2018 -0800
>
>     Add routines to load Lua programs that assume the path is UTF-8 on
> Windows.
>
> used lua_load with 5 params, that was introduced in lua 5.2 (if I'm not
> mistaken). Centos ships with lua 5.1, resulting in failing builds on that
> platform that has lua_load with 4 params only.

IMO that commit should be reverted, it extends the public Lua API just
to workaround an issue on Windows. We already override dofile/loadfile,
so I'm investigating whether that can be patched in an appropriate way.
(Aside from that there is also io.open, so the current fix is already
incomplete.)
--
Kind regards,
Peter Wu
https://lekensteyn.nl
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe

--

Naima is online.