Wireshark · Wireshark-dev: Re: [Wireshark-dev] Crash in epan/geoip_db.c

[Evan Huus <eapache@xxxxxxxxx>]

On Wed, Feb 22, 2017 at 09:50 Dario Lombardo <dario.lombardo.ml@xxxxxxxxx> wrote:

On Tue, Feb 21, 2017 at 11:38 PM, João Valverde <joao.valverde@xxxxxxxxxxxxxxxxxx> wrote:

Fixes 850393b57bdd7011780f4cf897d4a2467f58a673. Please push to Gerrit. Bonus points for fixing the cast too.

I pushed a patch that replaces g_free with free. Now the problem is that checkAPI doesn't allow free! No way to make petri-dish pass. We can:

checkAPI doesn't allow free because it also doesn't allow malloc; if the malloced memory is coming from library internals somewhere, does the library itself have a cleanup method we could call instead?

- merge without PD

- patch checkAPI to allow some forbidden calls in some files

Is it worth the latter or we should be fine with the former? 

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe