Wireshark-dev: [Wireshark-dev] Req for modification coverity build command line
From: Jaap Keuter <[email protected]>
Date: Wed, 17 Feb 2016 00:05:29 +0100
Hi,

For whomever handles the Coverity builds this is a request to add the '-P'
command line option for the compilation of the ASN.1 dissectors at least.

Little background for the uninitiated:
Coverity has what's called a build wrapper which 'intercepts' compilation
commands as they are executed by make. This clever trick allows it first hand
access to the 'compilation products' for static code analysis.
It collects source code, does analysis of this code and emits reports. These
reports contain references to files and line numbers and this is where things go
wrong.

Little background for the initiated:
The ASN.1 dissectors are sprinkled with #line references to the config and
template files these source lines originated from. Coverity analysis picks these
as the reference and indeed finds these files and includes them in the defect
database. The defect though has bearing on the resulting source file, for which
the actual reference is lost. It now is very hard to review the issue.
Some examples: CID 1204314, 1159375.

Little background on the request:
Adding the -P option to the GCC command line should inhibit generation of
linemarkers in the output from the preprocessor. I haven't tested it myself
(yet), and I'm not aware of the intimate details of the Coverity build setup,
but my hope is that it would make the analysis results of ASN.1 dissectors
intelligible for human consumption.

Kind regards,
Jaap