Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 52115: /trunk/epan/ /trunk/epan/: ad
From: Gerald Combs <[email protected]>
Date: Wed, 25 Feb 2015 16:12:20 -0800
On 2/25/15 2:59 PM, Jeff Morriss wrote:
> On 09/17/13 00:55, [email protected] wrote:
>> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=52115
>> User: etxrab
>> Date: 2013/09/16 09:55 PM
>> Log:
>>   Don't call gethostbyaddr() we have already read the local hosts
>> file, settle for that.
>> Directory: /trunk/epan/
>>    Changes    Path             Action
>>    +0 -30     addr_resolv.c    Modified
> Hmmm, this change means that on systems without C-ARES or GNU ADNS,
> external name resolution does not work at all (even for stuff that's in
> /etc/hosts).
> Any objection to reverting this?
> Or if we really want to kill off gethostbyaddr() we should disable "Use
> external name resolver" when we don't have an asynchronous name resolver
> (to make it obvious to the user s/he has a system where we don't want to
> do name resolutions).

No objection here, although reverting should include switching to
getaddrinfo. I haven't looked at it that closely but we might be to add
dns.c and make asynchronous resolution always-on: