Wireshark · Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] master f412c9a: Use ENC_BIG_ENDIAN when fetching FT_U?INT8 f

[Evan Huus <eapache@xxxxxxxxx>]

I didn't think single-byte fields could really have an endianess, so I
thought ENC_NA was appropriate for them?

Evan

On Sat, Dec 13, 2014 at 1:45 PM, Wireshark code review
<code-review-do-not-reply@xxxxxxxxxxxxx> wrote:
> URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f412c9a01aa031ef9f024ee1b8ec60bf4a73edb8
> Submitter: Bill Meier (wmeier@xxxxxxxxxxx)
> Changed: branch: master
> Repository: wireshark
>
> Commits:
>
> f412c9a by Bill Meier (wmeier@xxxxxxxxxxx):
>
>     Use ENC_BIG_ENDIAN when fetching FT_U?INT8 fields ...
>
>       (for some dissectors which fetch all other integral fields using
>        ENC_BIG_ENDIAN).
>
>     Change-Id: Ic18e3172aad76af12b12d6732c88497be22aed56
>     Reviewed-on: https://code.wireshark.org/review/5748
>     Reviewed-by: Bill Meier <wmeier@xxxxxxxxxxx>
>
>
> Actions performed:
>
>     from  7592d39   GSM SMS: fix 'msg_class' may be used uninitialized in this function warning
>     adds  f412c9a   Use ENC_BIG_ENDIAN when fetching FT_U?INT8 fields ...
>
>
> Summary of changes:
>  epan/dissectors/packet-6lowpan.c               |    2 +-
>  epan/dissectors/packet-acr122.c                |   10 +-
>  epan/dissectors/packet-aim-generic.c           |    2 +-
>  epan/dissectors/packet-ansi_801.c              |   68 ++---
>  epan/dissectors/packet-aodv.c                  |    2 +-
>  epan/dissectors/packet-arp.c                   |    8 +-
>  epan/dissectors/packet-aruba-erm.c             |    4 +-
>  epan/dissectors/packet-asterix.c               |    2 +-
>  epan/dissectors/packet-auto_rp.c               |    2 +-
>  epan/dissectors/packet-babel.c                 |   28 +-
>  epan/dissectors/packet-batadv.c                |    4 +-
>  epan/dissectors/packet-bgp.c                   |   42 +--
>  epan/dissectors/packet-bzr.c                   |    4 +-
>  epan/dissectors/packet-carp.c                  |    2 +-
>  epan/dissectors/packet-cdp.c                   |   20 +-
>  epan/dissectors/packet-chdlc.c                 |    2 +-
>  epan/dissectors/packet-clnp.c                  |    2 +-
>  epan/dissectors/packet-cops.c                  |   24 +-
>  epan/dissectors/packet-dcm.c                   |   18 +-
>  epan/dissectors/packet-dhcp-failover.c         |    2 +-
>  epan/dissectors/packet-diameter_3gpp.c         |    2 +-
>  epan/dissectors/packet-dis.c                   |   50 ++--
>  epan/dissectors/packet-dlsw.c                  |   52 ++--
>  epan/dissectors/packet-dns.c                   |   28 +-
>  epan/dissectors/packet-dtn.c                   |    4 +-
>  epan/dissectors/packet-dtp.c                   |    8 +-
>  epan/dissectors/packet-elmi.c                  |    2 +-
>  epan/dissectors/packet-epon.c                  |    2 +-
>  epan/dissectors/packet-erldp.c                 |    4 +-
>  epan/dissectors/packet-etch.c                  |    6 +-
>  epan/dissectors/packet-etsi_card_app_toolkit.c |   56 ++--
>  epan/dissectors/packet-fcels.c                 |   26 +-
>  epan/dissectors/packet-fcswils.c               |   22 +-
>  epan/dissectors/packet-fmtp.c                  |    6 +-
>  epan/dissectors/packet-foundry.c               |    4 +-
>  epan/dissectors/packet-giop.c                  |   10 +-
>  epan/dissectors/packet-gmr1_common.c           |    2 +-
>  epan/dissectors/packet-gsm_a_dtap.c            |   72 ++---
>  epan/dissectors/packet-gsm_a_gm.c              |    4 +-
>  epan/dissectors/packet-gsm_a_rr.c              |   16 +-
>  epan/dissectors/packet-gsm_sim.c               |    6 +-
>  epan/dissectors/packet-gtp.c                   |   48 ++--
>  epan/dissectors/packet-gtpv2.c                 |   10 +-
>  epan/dissectors/packet-h264.c                  |    4 +-
>  epan/dissectors/packet-hpsw.c                  |    2 +-
>  epan/dissectors/packet-http2.c                 |   30 +--
>  epan/dissectors/packet-iapp.c                  |    4 +-
>  epan/dissectors/packet-igmp.c                  |    2 +-
>  epan/dissectors/packet-igrp.c                  |   10 +-
>  epan/dissectors/packet-ipp.c                   |    2 +-
>  epan/dissectors/packet-ipv6.c                  |   22 +-
>  epan/dissectors/packet-isis-hello.c            |   28 +-
>  epan/dissectors/packet-isis-lsp.c              |   42 +--
>  epan/dissectors/packet-isl.c                   |    6 +-
>  epan/dissectors/packet-kink.c                  |    4 +-
>  epan/dissectors/packet-knxnetip.c              |    2 +-
>  epan/dissectors/packet-l2tp.c                  |   10 +-
>  epan/dissectors/packet-lacp.c                  |   16 +-
>  epan/dissectors/packet-lisp-tcp.c              |    2 +-
>  epan/dissectors/packet-lisp.c                  |   32 +--
>  epan/dissectors/packet-llrp.c                  |   16 +-
>  epan/dissectors/packet-lmp.c                   |   20 +-
>  epan/dissectors/packet-lon.c                   |   54 ++--
>  epan/dissectors/packet-maccontrol.c            |   10 +-
>  epan/dissectors/packet-macsec.c                |   16 +-
>  epan/dissectors/packet-marker.c                |    4 +-
>  epan/dissectors/packet-mikey.c                 |    4 +-
>  epan/dissectors/packet-mpeg-descriptor.c       |    2 +-
>  epan/dissectors/packet-mpls-pm.c               |   34 +--
>  epan/dissectors/packet-mpls-psc.c              |   12 +-
>  epan/dissectors/packet-nbns.c                  |   10 +-
>  epan/dissectors/packet-nhrp.c                  |    2 +-
>  epan/dissectors/packet-nlsp.c                  |   38 +--
>  epan/dissectors/packet-noe.c                   |    8 +-
>  epan/dissectors/packet-nsip.c                  |    2 +-
>  epan/dissectors/packet-nt-tpcp.c               |    4 +-
>  epan/dissectors/packet-osi-options.c           |   22 +-
>  epan/dissectors/packet-ospf.c                  |   42 +--
>  epan/dissectors/packet-packetbb.c              |    2 +-
>  epan/dissectors/packet-pathport.c              |   10 +-
>  epan/dissectors/packet-pdc.c                   |   18 +-
>  epan/dissectors/packet-pgsql.c                 |    2 +-
>  epan/dissectors/packet-pktc.c                  |    4 +-
>  epan/dissectors/packet-q2931.c                 |   88 +++---
>  epan/dissectors/packet-q931.c                  |   94 +++----
>  epan/dissectors/packet-q933.c                  |   80 +++---
>  epan/dissectors/packet-radius.c                |    2 +-
>  epan/dissectors/packet-radius_packetcable.c    |    4 +-
>  epan/dissectors/packet-rfid-felica.c           |    2 +-
>  epan/dissectors/packet-rfid-mifare.c           |    2 +-
>  epan/dissectors/packet-rfid-pn532-hci.c        |   12 +-
>  epan/dissectors/packet-rmt-lct.c               |    4 +-
>  epan/dissectors/packet-rpki-rtr.c              |    6 +-
>  epan/dissectors/packet-rtsp.c                  |    4 +-
>  epan/dissectors/packet-sap.c                   |   14 +-
> ... 28 lines suppressed ...
> ___________________________________________________________________________
> Sent via:    Wireshark-commits mailing list <wireshark-commits@xxxxxxxxxxxxx>
> Archives:    http://www.wireshark.org/lists/wireshark-commits
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
>              mailto:wireshark-commits-request@xxxxxxxxxxxxx?subject=unsubscribe