Wireshark-dev: Re: [Wireshark-dev] Wireshark PIDL generated dissectors
From: Matthieu Patou <[email protected]>
Date: Sun, 27 Oct 2013 10:41:34 -0700
On 10/27/2013 09:16 AM, [email protected] wrote:
I may have slightly misspoke about the patch in bug 9301 causing the compile errors, but the patch in bug 9301 had the same compile errors on Windows as the generated dissectors.  I originally committed the patch in r52734 before realizing the compiler errors which I corrected in r52735 (with a simple cast).
Yes I saw your patch for the bug 9301. But in theory I could resubmit the two patches because the errors weren't in the patch but in the use it made of the funcion in bug 9301
I don't have access to a Linux box, but I suspect if you used Linux to generate the patch in bug 9301, you won't see this issue either with the generated dissectors. It appears the generated dissectors need extra casting to compile on Windows and I didn't just want to make the fix in the Wireshark source.
Also do you have some kind of buildfarm, I'm ok to build patches there before submissions.

Matthieu.

-----Original Message-----
From: Matthieu Patou <[email protected]>
To: mmann78 <[email protected]>; wireshark-dev <[email protected]>
Cc: abartlet <[email protected]>; samba-technical <[email protected]>
Sent: Sat, Oct 26, 2013 7:26 pm
Subject: Re: [Wireshark-dev] Wireshark PIDL generated dissectors

On 10/21/2013 12:48 PM, [email protected] wrote:
>
> Checked most of the patches into r52744 (http://anonsvn.wireshark.org/viewvc?view=revision&revision=52744)
>   
> Didn't integrate
> 0010-frsrpc-Regenerate-frsrpc-due-to-changes-in-the-pidl-.patch
> 0016-Regenerate-the-dnserver.patch
>
> due to compile errors on Windows from applying the patch in bug 9301 
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9301).
>
> See r52735 (http://anonsvn.wireshark.org/viewvc?view=revision&revision=52735) 
for how it was fixed.  Not sure if the PIDL compiler has to be changed for this 
one.
Can you tell me what were the compile errors on linux, it's seems just 
fine with just this patch on top of the recent svn trunk.

I just have warnings for dnsserver:
/home/mat/workspace/wireshark/epan/dissectors/packet-dcerpc-dnsserver.c: 
In function ‘dnsserver_dissect_element_DNS_RPC_RECORD_Type’:
/home/mat/workspace/wireshark/epan/dissectors/packet-dcerpc-dnsserver.c:1381:2: 
warning: passing argument 7 of ‘dnsserver_dissect_enum_DNS_RECORD_TYPE’ 
from incompatible pointer type [enabled by default]
/home/mat/workspace/wireshark/epan/dissectors/packet-dcerpc-dnsserver.c:1008:1: 
note: expected ‘guint32 *’ but argument is of type ‘guint16 *’
/home/mat/workspace/wireshark/epan/dissectors/packet-dcerpc-dnsserver.c: 
At top level:
/home/mat/workspace/wireshark/epan/dissectors/packet-dcerpc-dnsserver.c:1261:1: 
warning: ‘dnsserver_dissect_element_DNS_RPC_NAME_NameLength’ defined but 
not used [-Wunused-function]
/home/mat/workspace/wireshark/epan/dissectors/packet-dcerpc-dnsserver.c:1269:1: 
warning: ‘dnsserver_dissect_element_DNS_RPC_NAME_Name’ defined but not 
used [-Wunused-function]
/home/mat/workspace/wireshark/epan/dissectors/packet-dcerpc-dnsserver.c:1276:1: 
warning: ‘dnsserver_dissect_element_DNS_RPC_NAME_Name_’ defined but not 
used [-Wunused-function]

Matthieu


-- 
Matthieu Patou
Samba Team
http://samba.org