Wireshark · Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 45175: /trunk/epan/ /trunk/epan/: prefs.c

[Guy Harris <guy@xxxxxxxxxxxx>]

On Sep 27, 2012, at 1:47 PM, Gerald Combs <gerald@xxxxxxxxxxxxx> wrote:

> We're using it in trunk-1.8 too, even though we shouldn't (the minimum
> version of GLib there is 2.14). I switched to strcmp in r45180.

...and, in all of the cases in 1.8 (the ones in main_menubar.c), either tok has already been checked to make sure it's non-null or is otherwise known to be non-null (g_strstrip() returns its argument, which has been checked to be non-null, and that's what's being assigned to tok), so there's no need to use g_strcmp0() there (so we could use strcmp() in the trunk as well).