Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 42530: /trunk/epan/ /trunk/epan/diss
From: "Maynard, Chris" <[email protected]>
Date: Wed, 9 May 2012 21:40:35 -0400
I just recently looked at the RADIUS dissector and had noticed that the "encrypt=" took a value of 1-3 and meant to go back and look at that, but got disstracted with some LCP changes.  Thanks for fixing that!

- Chris

________________________________________
From: [email protected] [[email protected]] On Behalf Of [email protected] [[email protected]]
Sent: Wednesday, May 09, 2012 9:01 PM
To: [email protected]
Subject: [Wireshark-commits] rev 42530: /trunk/epan/ /trunk/epan/dissectors/: packet-radius.c packet-radius.h /trunk/epan/: radius_dict.l

http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=42530

User: guy
Date: 2012/05/09 06:01 PM

Log:
 Get rid of remaining Booleans-as-encoding-arguments in
 proto_tree_add_item() calls.

 For RADIUS, this means that, for string attributes that are encrypted,
 we need separate fields for the encrypted and decrypted versions, the
 former of which is an FT_BYTES (as its value is *NOT* a text string!)
 and the latter of which is FT_STRING.

 While we're at it:

        make some routines static that don't need to be exported;

        "encrypt=" takes a value between 1 and 3 - get the value from
        the dictionary and store it, and only do User-Password-style
        decryption for encrypt=1 attributes;

        rename "hf64" to "hf_alt", as it's a general "alternate field",
        used for 64-bit values for integral attributess, IPv6 addresses
        for "combo IP" attributes, and encrypted values for string
        fields;

        give the URL for the FreeRADIUS dictionary file format man page.

Directory: /trunk/epan/dissectors/
  Changes    Path               Action
  +51 -22    packet-radius.c    Modified
  +2 -2      packet-radius.h    Modified

Directory: /trunk/epan/
  Changes    Path             Action
  +12 -12    radius_dict.l    Modified

___________________________________________________________________________
Sent via:    Wireshark-commits mailing list <[email protected]>
Archives:    http://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
             mailto:[email protected]?subject=unsubscribe
CONFIDENTIALITY NOTICE: The information contained in this email message is intended only for use of the intended recipient. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please immediately delete it from your system and notify the sender by replying to this email.  Thank you.