Wireshark-dev: Re: [Wireshark-dev] Fix the last non-gtkitemfactory stuff for use with -DGTK_DIS
From: Anders Broman <[email protected]>
Date: Thu, 14 Jul 2011 14:49:33 +0200
Joerg Mayer skrev 2011-07-14 14:09:
On Thu, Jul 14, 2011 at 01:51:15PM +0200, Anders Broman wrote:
I'm inclined to #if 0 out proto_help.c and let the ones that supplied
the code fix it.
Personally I don't mind - it's 1.7 and thus we are free to disable features
for a while.Is the sep_entry variable stuff in menus.c easy to fix?
(gtk/menus.c:4382:5: error: ‘GtkItemFactoryEntry’ undeclared)
Probably, it's been a while since I looked at the code but I think merge_all_tap_menus() is basically unused
currently in MAIN_MENU_USE_UIMANAGER code path.
While we are talking about it: Should we finally make the new UI_MANAGER
code mandatory for everyone - this would remove lots of #ifdefs again.

Ciao
      Joerg

I'm not sure, that would remove quite a few statistics functions and I'm not sure how long it would take to put them back in or how much time I can spend on it. I wonder if it's possible to "mix" UI_MANAGER and GtkItemFactory code in the menu for the time beeing. So at lest we could exercise the huge portion of code converted.
Regards
Anders