Wireshark · Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 36755: /trunk/epan/dissectors/ /trunk/epan/dissectors/:

Huge thanks to our Platinum Members Endace and LiveAction,
and our Silver Member Veeam, for supporting the Wireshark Foundation and project.

Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 36755: /trunk/epan/dissectors/ /trun

From: Stig Bjørlykke <stig@xxxxxxxxxxxxx>

Date: Thu, 21 Apr 2011 15:41:18 +0200

On Thu, Apr 21, 2011 at 3:32 PM,  <alagoutte@xxxxxxxxxxxxx> wrote:
>  Fix Dead Store (Dead nested assignment) Warning found by Clang

-					msg_type = tvb_get_ntohs(tvb, (tmp_idx+=2));
+					msg_type = tvb_get_ntohs(tvb, tmp_idx);

Are you sure this is correct?  What about "tmp_idx+2"?


-- 
Stig Bjørlykke

Follow-Ups:
- Re: [Wireshark-dev] [Wireshark-commits] rev 36755: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-l2tp.c
  - From: Alexis La Goutte

Prev by Date: Re: [Wireshark-dev] Use of wireshark to interpret input data that does not depend on any other existing protocols
Next by Date: Re: [Wireshark-dev] Compilation error 2
Previous by thread: Re: [Wireshark-dev] Compilation error 2
Next by thread: Re: [Wireshark-dev] [Wireshark-commits] rev 36755: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-l2tp.c
Index(es):
- Date
- Thread

© Wireshark Foundation · Privacy Policy

Facebook·Mastodon·Twitter·YouTube