Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 21556: /trunk/epan/ /trunk/epan/: pr
From: "Anders Broman" <[email protected]>
Date: Tue, 24 Apr 2007 23:56:27 +0200
-----Ursprungligt meddelande-----
Från: [email protected]
[mailto:[email protected]] För Ulf Lamping
Skickat: den 24 april 2007 23:05
Till: Developer support list for Wireshark
Ämne: Re: [Wireshark-dev] [Wireshark-commits] rev 21556: /trunk/epan/
/trunk/epan/: proto.c proto.h - all buildbots red now :-(

Anders Broman wrote:
>> Hi,
>> I have no problem with backing out my changes but a
>> Proto_... function should not be local to iuup in my opinion.
>> Perhaps it should be renamed iuup_proto_.. instead until
>> We have "the real thing" in proto.c
>>
>> What do others think?
>>   
>Well, first of all, we shouldn't have a buildbot going into deep red for 
>a long time, so there's something to be done.

>I'll fully agree that a function starting with proto_ shouldn't be in 
>any dissector code - a name clash will be the result sooner or later - 
>and today is sooner ;-)

>Could you please:

>1.) fix the issue in iuup by prepending iuup_ so the buildbot get's 
>green again - I'm currently waiting for it :-(

Joerg beat me to it.

>2.) if your new function doesn't follow the common function pattern, fix 
>this issue in your implementation (I didn't had a look at the code in 
>proto myself)


Well what pattern it should have is being discussed.
As I see it:
Alt
1) Leave it as it is and change other proto_add.. functions to behave
similarly.
1b) Leave the signature but rename it to something like
proto_tree_add_bits_ret_val() and add similar functions for other stuff.

2) use(proto_tree* tree, int hf, tvbuff_t* tvb, int offset, int bit_offset,
guint bits) as in iuup

3) use (proto_tree *tree, int hf_index, tvbuff_t *tvb, gint bit_offset, gint
no_of_bits, gboolean little_endian)

Other?
Regards
Anders



_______________________________________________
Wireshark-dev mailing list
Wireshar[email protected]
http://www.wireshark.org/mailman/listinfo/wireshark-dev