Wireshark-dev: Re: [Wireshark-dev] VoIP Calls Option Doesn't Work In V0.99.1pre1
From: Cvetan Ivanov <[email protected]>
Date: Sat, 10 Jun 2006 04:13:03 +0300
Hello,

I've submitted a patch for this few days ago, but it seems it did not make it in.
Could somebody check it in now, when things have settled somehow?

The reason for h323 call analysys not working is tmp_h323info->guid being a pointer itself, and does not need referencing in the memcmp call.


Best regards,

Cvetan

Keith French wrote:
The VoIP Calls option on the stats menu worked fine under Ethereal V0.10.14, but in 0.99.0 it stopped working. Someone said it should be already fixed in a development release, but in WireShark V0.99.1pre1 it is still broken. The problem is that it does not group all of the H.323 packets from a call together with a one line entry for it. Instead it lists every packet on a separate line making the graph & prepare filter options rather pointless as they work on the one frame. I am using this on Windows XP Pro SP2, if this helps. I'm not sure which list I should really post this to, so I have put it on both the dev and user lists. Thanks.
Index: gtk/voip_calls.c
===================================================================
--- gtk/voip_calls.c	(revision 18189)
+++ gtk/voip_calls.c	(working copy)
@@ -1698,7 +1698,7 @@
 			tmp_listinfo=list->data;
 			if (tmp_listinfo->protocol == VOIP_H323){
 				tmp_h323info = tmp_listinfo->prot_info;
-				if ( (memcmp(&tmp_h323info->guid, &guid_allzero, GUID_LEN) != 0) && (memcmp(&tmp_h323info->guid, &pi->guid,GUID_LEN)==0) ){ 
+				if ( (memcmp(tmp_h323info->guid, &guid_allzero, GUID_LEN) != 0) && (memcmp(tmp_h323info->guid, &pi->guid,GUID_LEN)==0) ){ 
 					strinfo = (voip_calls_info_t*)(list->data);
 					break;
 				}