Wireshark · Wireshark-commits: [Wireshark-commits] master 49fcee3: Qt: don't append a second extension to save file names

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=49fcee3fcb997036f8677af081a5cbecab7c07e0
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

49fcee3 by Роман Донченко (dpb@xxxxxxxxxxxxxx):

    Qt: don't append a second extension to save file names
    
    When checking if the file already has one of the possible extensions,
    MainWindow::fileAddExtension reuses file_suffix between iterations and
    appends to it each time, so it ends up checking for the wrong suffix for all
    extensions except the first one. Scope file_suffix to the for loop to
    fix that.
    
    Change-Id: Idbc5a619a4793d8c477bfd88305cdb44ea844e13
    Reviewed-on: https://code.wireshark.org/review/19123
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  983334f   The version lists are sequences of 1-byte integers, not strings.
    adds  49fcee3   Qt: don't append a second extension to save file names


Summary of changes:
 ui/qt/main_window.cpp |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)