Wireshark · Wireshark-commits: [Wireshark-commits] master 983334f: The version lists are sequences of 1-byte integers, not strings.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=983334fc1e6f95c88b9e35176feedf66d9dd484d
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

983334f by Guy Harris (guy@xxxxxxxxxxxx):

    The version lists are sequences of 1-byte integers, not strings.
    
    Show each version in the list independently as an item.
    
    Perhaps the Set Protocol response version lists seen have only one
    version, but the presence of a version-0 terminator suggests that it
    could contain multiple versions, so dissect it as such.
    
    For FT_STRINGZ values, let proto_tree_add_item() determine the length -
    pass a length of -1.  If we need the length, use
    proto_tree_add_item_ret_length().
    
    Change-Id: I5954ccac34f9e462c6d43e9a213974cf818f4d0d
    Reviewed-on: https://code.wireshark.org/review/19134
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  0af0532   Qt: Fixup the currentOutputDeviceName Q_PROPERTY.
    adds  983334f   The version lists are sequences of 1-byte integers, not strings.


Summary of changes:
 epan/dissectors/packet-tns.c |   73 ++++++++++++++++++++++++++++++++++--------
 1 file changed, 59 insertions(+), 14 deletions(-)