Alexis La Goutte
changed
bug 8972
| What |
Removed |
Added |
| Status |
UNCONFIRMED
|
RESOLVED
|
| Resolution |
---
|
FIXED
|
Comment # 6
on bug 8972
from Alexis La Goutte
(In reply to comment #4)
> (In reply to comment #3)
> > + dscp_item = proto_tree_add_text(tree, tvb, offset, 2, "DSCP Exception");
> > [...]
> > + dscp_item = proto_tree_add_text(tree, tvb, offset, 2,
> > + "DSCP Range description");
> >
> > it is possible to replace by proto_tree_add_item ? (with FT_NONE hf type ?)
> > (you try to remove proto_tree_add_text...)
>
> Sure.
>
> > + expert_add_info_format(pinfo, item, PI_MALFORMED, PI_ERROR,
> > + "Invalid DSCP Value");
> > It is possible to use the new expert "framework" ? (i know 802.11 dissector
> > is not yet convert to the new "framework"
>
> I'm not sure what this is referring to. The "filterable expert infos" from
> Michael Mann? If so, I'll try to do something similar to the 'Batch of
> filterable expert infos.' commit from a month ago.
Yes !
Thanks
Committed in revision 50908
You are receiving this mail because:
- You are watching all bug changes.
