Comment # 5
on bug 8019
from Evan Huus
Didn't quite answer my question, but I wasn't very clear in what I was asking.
I understand the common header may be shared among multiple TLVs. My question
was why you were creating an entire new tvbuff to pass to the TLV decoder when
you could just pass the original tvbuff and the offset to start decoding at.
Usually new tvbuffs are only created when passing to an actual sub-dissector in
a separate file, and for internal TLVs and headers we just pass around an
offset.
Not that what you've done is wrong in any real way, it's just a little slower.
You are receiving this mail because:
- You are watching all bug changes.
