https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7824
Guy Harris <guy@xxxxxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #9323|review_for_checkin? |review_for_checkin-
Flags| |
--- Comment #7 from Guy Harris <guy@xxxxxxxxxxxx> 2012-10-09 10:00:36 PDT ---
Comment on attachment 9323
--> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=9323
Patch to diam_dict.l
The diam_dict.l patch will leak the allocated file path string "fname" if the
open fails.
The existing code is safe - the only place fh is used afterwards is in the
debug message, where it'll just be printed as 0x00000000 or 0x0000000000000000
or whatever the way %p prints a null pointer, if it's null, and in the return
statement, where, if it's null, the routine will return null, which is what it
should do in that case.
So that patch need not and should not be applied.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
