Wireshark-bugs: [Wireshark-bugs] [Bug 4753] New dissector: JSON
Date: Fri, 14 May 2010 13:58:46 -0700 (PDT)

--- Comment #4 from Chris Maynard <christopher.maynard@xxxxxxxxx> 2010-05-14 13:58:45 PDT ---
(In reply to comment #3)
> Can you try with attached tvbparse patch?
Looks good.

> I can add, but ietf.org, or rfc-editor.org? or maybe http://json.org?
Any of those will do.  Maybe rfc-editor.org as well as the json link?

The only other comment I would have is that it might be nice to display a
summary of the Object on the Object line so you wouldn't necessarily have to
expand it to get at all the details.  i.e., instead of:
- Object
  + Member Key: "C"
  + Member Key: "D"

you might instead have something like:
+ Object (C=VIS, D=Object)

... and this:
- Object (C=VIS, D=Object)
  + Member Key: "C" = VIS
  - Member Key: "D" = Object
    + Object (u=Array)

You get the idea.  Not sure how hard that would be to do or if it would even be
feasible for you or worth it to you.  Just an idea.  Other than that, I don't
have much else to say about this dissector.  Looks good.

Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.