Wireshark-bugs: [Wireshark-bugs] [Bug 4753] New dissector: JSON

Jakub Zawadzki <[email protected]> changed:

           What    |Removed                     |Added
   Attachment #4651|                            |review_for_checkin?
               Flag|                            |

--- Comment #3 from Jakub Zawadzki <[email protected]> 2010-05-14 13:27:59 PDT ---
Created an attachment (id=4651)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=4651)
Patch for tvbparse.

(In reply to comment #2)
> Some initial feedback, tested against r32806:


> 2) Forgetting Frame #2, only Frame #1 appears to be dissected as json.  I don't
> notice any difference in Frames #3 and #4 as compared to Wireshark 1.2.8.

Can you try with attached tvbparse patch?

> 3) Why do frames #3-4 display "(application/json)" twice in the Info column?

If whole packet isn't dissected as JSON, I'm passing it to previous
(data-text-lines) dissector, which also adds content-type to COL_INFO...

> 4) Any XXX's need further attention?

It'd be nice to have key filtering.

> 5) fuzz-testing?

A little, still cause tvbparse is mainly in used, which is fuzz-tested a lot
(i.e. by xml)

> 6) Instead of just indicating RFC 4627, maybe you could add a link to it, such
> as:
> http://www.ietf.org/rfc/rfc4627.txt?number=4627

I can add, but ietf.org, or rfc-editor.org? or maybe http://json.org?

Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.