Wireshark · Ethereal-dev: [Ethereal-dev] Re: [Ethereal-cvs] rev 17107: /trunk/epan/dissectors/: packet-socks.c packet-tcp.c pa

[Ulf Lamping <ulf.lamping@xxxxxx>]

sahlberg@xxxxxxxxxxxx wrote:
> User: sahlberg
> Date: 2006/01/26 04:50 PM
>
> Log:
>  rewrite of the tcp sequence number analysis code to hopefully make it cleaner and easier to maintain and extend.
>  
>  i have tested it with many captures   but this used to be fragile and delicate code  so there might be some regressions that will need to be addressed once identified.
>
>   
Hi Ronnie!

Didn't had a look at your actual code, but I'm pleased to hear that you 
try to cleanup the (obviously messy) TCP reassembly code.

I had a quick look at that code a while before and I really do agree 
that it needed some cleanup.

So even if it breaks up some things today, it may help us in the long 
term a lot :-)

Regards, ULFL

P.S.: It reminds me of the work I've done (and introduced a lot of new 
bugs) in the capturing code. But this was the only way to get a clean 
code base for any further development ...