Hi,
I have checked in a change to use col_set_fence() after writing the column
info for one PDU, which should take care of the problem. You could use the
same solution in your dissector. I must have missed that mail.
I think a change had been made to the file after the diff file was produced
making it fail.
Brg
Anders
Hi Anders,
I tested SVN 16978 and it is working fine for the flow graph itself. Thanks.
But the change you made on Camel breaks displaying TCAP primitives that have
several components (as in the Camel sample capture:
http://wiki.ethereal.com/SampleCaptures?action=AttachFile&do=get&target=came
l.pcap )
And I don't know how to solve it. I already mentioned this issue back in
August 05 for another protocol
(http://www.ethereal.com/lists/ethereal-dev/200508/msg00037.html)
But we didn't came to a conclusion on this.
Also, can you tell me what I did wrong for the patch that forced you to
apply by hand? (I'd like to avoid such issues in the future :) )
Regards,
Olivier.
> -----Original Message-----
> From: ethereal-dev-bounces@xxxxxxxxxxxx
> [mailto:ethereal-dev-bounces@xxxxxxxxxxxx] On Behalf Of Anders Broman
> Sent: samedi 7 janvier 2006 12:13
> To: 'Ethereal development'
> Subject: SV: [Ethereal-dev] [patch] flow graph enhancement
>
> Hi,
> Checked in, I had to apply the patch by hand so please check it.
> I also made a change to the camel dissector not display the TCAP Info.
>
> Brg
> Anders
>
> -----Ursprungligt meddelande-----
> Från: ethereal-dev-bounces@xxxxxxxxxxxx
> [mailto:ethereal-dev-bounces@xxxxxxxxxxxx] För Jacques,
> Olivier (OCBU-Test
> Infra)
> Skickat: den 6 januari 2006 14:29
> Till: Ethereal development
> Ämne: [Ethereal-dev] [patch] flow graph enhancement
>
> Hello again,
>
> while working with flow graph, I generally want to see
> message names instead of protocol names as label for the
> arrows. This greatly eases troubleshooting.
> Here is a patch that:
> - Replaces the arrow labels by the beginning of the COLINFO
> column if available (usually containing message names/types).
> - Change the comment area to be "protocol: colinfo_content"
>
> As examples, here are also two snapshots. One with a
> SCTP/M3UA flow, another one with a Camel + ISUP call.
>
> Olivier.
>
>
> _______________________________________________
> Ethereal-dev mailing list
> Ethereal-dev@xxxxxxxxxxxx
> http://www.ethereal.com/mailman/listinfo/ethereal-dev
>
_______________________________________________
Ethereal-dev mailing list
Ethereal-dev@xxxxxxxxxxxx
http://www.ethereal.com/mailman/listinfo/ethereal-dev
