Wireshark · Ethereal-dev: Re: [Ethereal-dev] Proposal for mew memory allocation API

[Guy Harris <gharris@xxxxxxxxx>]

didier wrote:

> BTW there's a bug in packet-eth.c around line 300
>  ti = proto_tree_add_protocol_format(parent_tree, proto_eth, tvb, 0, 
> ETH_HEADER_SIZE,
>
> Without Mac resolution get_ether_name *is* ether_to_str so it pushes 
> four ether_to_str results but there's only 3 buffers...

The real problem is that it pushes four ether_to_str results - if name 
resolution is off, things such as

	Source address: 172.20.4.17 (172.20.4.17)

or

	Destination: 00:0c:0a:fb:20:21 (00:0c:0a:fb:20:21)

are written, but I suspect one copy of the address is enough:

	Source address: 172.20.4.17

	Destination: 00:0c:0a:fb:20:21

and the like.