Wireshark · Ethereal-dev: Re: [Ethereal-dev] Don't release: Console warnings with latest changes in prefs.c!

[Ulf Lamping <ulf.lamping@xxxxxx>]

Gerald Combs wrote:

>That was my doing.  It was intended to fix a bug found by Steve Grubb:
>
>http://bugs.ethereal.com/bugzilla/show_bug.cgi?id=217
>
>The GStrings weren't being initialized properly.  It should be fixed now.
>  
>
Yes, it's fixed now.


Is there a special idea behind using the GStrings static? Seems a bit
strange to me...

Two reasons against:

a) not multithread safe (should be currently no problem)
b) will keep using memory, but this function is used only at startup

Why not allocate the strings at function start and simply free them near
the end of the function?

Regards, ULFL