Wireshark · Ethereal-dev: [Ethereal-dev] make-version.pl breaks w/ non-english locales

[Thomas Anders <thomas.anders@xxxxxxxxxxxxx>]

make-version.pl calls "svn info" to get the SVN timestamp for SVN 
builds. However, it parses the output of "svn info" directly looking for 
"Last Changed Date: ", thus assuming an english locale. However, at 
least on my SuSE 9.3 box, svn has been i8n'ed and has localized output:

foo# LC_ALL=de_DE.UTF-8 svn info | grep datum
Letztes �nderungsdatum: 2005-06-07 07:50:28 +0200 (Di, 07 Jun 2005)
foo# LC_ALL=de_DE.UTF-8 make svnversion.h
/usr/bin/perl ./make-version.pl
Version configuration file version.conf not found.  Using defaults.
This is a build from SVN (or a SVN snapshot).
Fetching version with command "svn info".
SVN version tag will be computed.
svnversion.h has been updated.
foo# cat svnversion.h
/* #define SVNVERSION "" */

foo# LC_ALL=C svn info | grep Date
Last Changed Date: 2005-06-07 07:50:28 +0200 (Tue, 07 Jun 2005)
foo# LC_ALL=C make svnversion.h
/usr/bin/perl ./make-version.pl
Version configuration file version.conf not found.  Using defaults.
This is a build from SVN (or a SVN snapshot).
Fetching version with command "svn info".
SVN version tag will be computed.
svnversion.h has been updated.
foo# cat svnversion.h
#define SVNVERSION "SVN 20050607075028"

I think we should either replace "svn info" with something better (thus 
also eliminating the dependency on a command-line svn client) or at 
least force the perl script to use an appropriate locale (trivial fix).


+Thomas

--
Thomas Anders (thomas.anders at blue-cable.de)