Wireshark · Ethereal-dev: [patch] asn2eth [was: RE: [Ethereal-dev] [Patch] Camel dissector]

["Jacques, Olivier (OCBU-Test Infra)" <olivier.jacques@xxxxxx>]

> Outstanding bugs: 
> - To be fixed before inclusion in Ethereal: when generating 
> packet-camel.[ch], I get an error which seems to have no 
> impact on the resulting packet-camel.[ch], but which I don't 
> know how to fix! Any help appreciated :) Traceback (most 
> recent call last):
>   File "../../tools/asn2eth.py", line 4485, in ?
>     eth_main()
>   File "../../tools/asn2eth.py", line 4460, in eth_main
>     ectx.output.make_single_file()
>   File "../../tools/asn2eth.py", line 1503, in make_single_file
>     os.unlink(fn)
> OSError: [Errno 2] No such file or directory:
>
'c:\\transfer\\ethereal\\winbuild\\ethereal\\asn1\\camel\\packet-camel-h
f.c'

This was due to the handling (deletion) of the files generated by
asn2eth.
The patch attached fixes it by creating a table of unique files at the
time of file deletion. This way, current asn2eth behaviour is not
modified.
I think this was not discovered before, because of the structure of the
asn1 file. But I'm not completely sure.

The camel dissector (packet-camel.[ch]) can be checked-in now.

Olivier.

Attachment: asn2eth.diff
Description: asn2eth.diff