Wireshark · Ethereal-dev: Re: [Ethereal-dev] [Patch] Ethereal crashes by trying to edit preferences

[Guy Harris <gharris@xxxxxxxxx>]

Nathan Jennings wrote:

> Thanks a ton for including this; it's a huge timesaver.
>
> Please see attached patch.
>
> -Nathan
>
>
> ------------------------------------------------------------------------
>
> Index: gtk/capture_prefs.c
> ===================================================================
> --- gtk/capture_prefs.c	(revision 13296)
> +++ gtk/capture_prefs.c	(working copy)
> @@ -681,7 +681,7 @@
>  	gint i;
>  	
>  	for (i=0; i < IFOPTS_CLIST_COLS; i++) {
> -		if (text[i] != NULL) {
> +		if (*text[i] != NULL) {
>  			g_free(text[i]);
>  			text[i] = NULL;
>  		}

That means that if text[i] happens to be a null string, even if it's a 
g_strdup()ed null string, it won't get freed.

I checked in a change to replace

	text[N] = "";

(for various values of N) with

	text[N] = g_strdup("");

(there was one place where that was already being done).