Wireshark · Ethereal-dev: Re: Re: [Ethereal-dev] IAX2 enhancements (was Re: Patch to packet-iax2 - add support for iLBC codec)

[ronnie sahlberg <ronniesahlberg@xxxxxxxxx>]

There are some problems with the patch.

Cosmetic one:
It replaces the explicit hf variables with an array,   that is
inconsistent with all the other dissectors and might be confusing for
someone browsing the source.

Serious one:
It creates a lot of hf fields with the same abbrev    such as
"iax2.iax.unknowndata"
Ethereal doesnt really like to have multiple different hf fields with
the same abbrev.
This one must be fixed.


Please massage the patch and resend it.



On Fri, 25 Jun 2004 17:00:34 +0100, Richard van der Hoff
<richardv@xxxxxxxxxxxxx> wrote:
> 
> Giles Scott wrote:
> > Hi Richard,
> >
> > Very nice!
> > Any chance you could place the calling number/ called number/username on
> > information Element line, rather than having to expand the IE?
> > 
> Your wish is my command.
> 
> Ronnie, thanks for committing my earlier changes. Please find another
> patch attached :)
>