Wireshark · Ethereal-dev: [Ethereal-dev] Re: [Ethereal-cvs] cvs commit: ethereal/gtk file_dlg.c follow_dlg.c main.c print_dlg.

[Ulf Lamping <ulf.lamping@xxxxxx>]

Joerg Mayer wrote:

> jmayer      2004/06/25 02:04:02 CDT
>
>  Modified files:
>    gtk                  file_dlg.c follow_dlg.c main.c 
>                         print_dlg.c 
>  Log:
>  tmpnam() really should not be used for security reasons.
>  Replace it where used and update README.developer accordingly.
>  
>  Revision  Changes    Path
>  1.122     +2 -2      ethereal/gtk/file_dlg.c
>  1.67      +2 -2      ethereal/gtk/follow_dlg.c
>  1.447     +2 -2      ethereal/gtk/main.c
>  1.79      +2 -2      ethereal/gtk/print_dlg.c
>
>  
Hmmm, when looking into mkstemp.c, the return value from the function 
mkstemp() is an opened file descriptor for reading and writing, while 
tmpnam() returns only the filename.

Your changes just don't work!!!

Regards, ULFL