Wireshark · Ethereal-dev: Re: [Ethereal-dev] OSPF-TE patch for GMPLS

[Carles Kishimoto <ckishimo@xxxxxxxxx>]

You're right !
I didn't notice it was not used by RSVP dissector.
I just wrote it, where all gmpls_*_str[] are defined...

Regards,

Carles

On Sat, 2004-06-19 at 11:53, Guy Harris wrote:
> On Fri, Jun 18, 2004 at 05:05:12PM +0200, Carles Kishimoto wrote:
> > I've made some modifications in the CVS ethereal version in order to get
> > support for GMPLS extensions draft:
> > 	draft-ietf-ccamp-ospf-gmpls-extensions-12.txt.
> > A patch is attached.
> 
> Checked in.
> 
> Is there some reason why "gmpls_protection_cap_str[]" is defined in
> "packet-rsvp.c", as the RSVP dissector doesn't use it? 
> "gmpls_switching_type_str[]" and "gmpls_lsp_enc_str[]" are used both in
> the RSVP dissector and other dissectors, so it makes sense to define
> them in one of the dissector source files and export them to others,
> but, if "gmpls_protection_cap_str[]" is used only in the OSPF dissector,
> it should perhaps be defined there.