Wireshark · Ethereal-dev: Re: [Ethereal-dev] [PATCH] enhancements to packet-clnp.c COTP dissection

[Guy Harris <gharris@xxxxxxxxx>]

On Mon, Jun 07, 2004 at 09:03:16PM +0100, matthew.bradley@xxxxxxxxxxxxx wrote:
> Attached is a patch making the following enhancements to COTP dissection:
> 
> 1. Searchable fields for cotp.src-tsap, cotp.src-tsap-bytes, cotp.dst-tsap
> and cotp.dst-tsap-bytes as previously submitted, but with options Auto and
> Bytes only as suggested by Guy.
> 
> 2. Fields cotp.type.XX where XX is the TPDU type: CR, CC, AK, DT etc. This
> allows easy filtering and searching.
> 
> The patch sets the field type for the TPDU type fields to FT_NONE. I notice,
> however, that if I right click an instance of the field in the protocol tree
> and choose "Apply as filter->Selected" or similar, the display filter string
> is set to frame[19:1] == d2 (or whatever) instead of cotp.type.cc (or
> whatever). Is this a "feature" of the GUI, or a bug, or am I misusing the
> FT_NONE field type?
> 
> This patch is a replacement for the previous patch submitted for source and
> destination TSAP searching.

...which means it doesn't apply to the current CVS version of
packet-clnp.c, as that version has the previous patch applied.

It also has some other changes applied since then, so it's not as if we
could just apply the new patch to the version before your previous patch
was applied.

Could you send us a patch against the current CVS version?