Wireshark · Ethereal-dev: Re: [Ethereal-dev] Patch for rtp_analysis

["Lars Ruoff" <lars.ruoff@xxxxxxxxxxxxxxxxxx>]

good idea to centralize the RTP payload type definitons.
But why not directly in packet-rtp.h?
Note that rtp_stream_dlg.h should use the include also, instead of
redefining the PTs

----- Original Message ----- 
From: "Guy Harris" <guy@xxxxxxxxxxxx>
To: "Lars Ruoff" <lars.ruoff@xxxxxxxxxxxxxxxxxx>
Cc: "Ethereal-Dev" <Ethereal-dev@xxxxxxxxxxxx>
Sent: Thursday, September 25, 2003 9:39 PM
Subject: Re: [Ethereal-dev] Patch for rtp_analysis


>
> On Sep 25, 2003, at 12:26 AM, Lars Ruoff wrote:
>
> > Patch for the rtp-analysis code:
>
> Checked in, with some changes (payload type 19 added to "rtp_pt.h", and
> "gtk/rtp_analysis.c" changed to get RTP payload types from that header;
> "%d"s used to print unsigned values changed to "%u"s; (statinfo->flags
> & STAT_FLAG_xxx == 0) changed to !(statinfo->flags & STAT_FLAG_xxx), as
> GCC suggested additional parentheses for the former, i.e.
> ((statinfo->flags & STAT_FLAG_xxx) == 0) - relational operators such as
> == have *higher* precedence than bitwise operators such as & - and to
> make it a bit clearer that we're testing for the bit not being set).
>