Wireshark · Ethereal-dev: Re: [Ethereal-dev] Re: Rearrange source tree?

[Richard Urwin <richard@xxxxxxxxxxxxxxx>]

On Saturday 13 Sep 2003 10:57 am, Biot Olivier wrote:
> There's nothing that forbids us to put common User Interface (or
> front end) code in ./ui/ and to have a ./ui/gtk1 and ./ui/gtk2/ and
> ./ui/tethereal/ and ./ui/native/Win32 for instance. Or as Guy
> proposed, something more in the lines ./ui/gtk/ for the GTK common
> stuff, and then ./ui/gtk/gtk1/ and ./ui/gtk/gtk2/ for the
> version-specific code.

In the color_filter dialog there is exactly one GTK2-only function. The 
rest of the code is largely common with two or three lines here and 
there in most functions that are GTK1 or GTK2. IMHO, trying to split 
out all GTK differences would lead to massive code duplication and 
divergence hell. Yes it is messy at the moment, but the alternative is 
(IMO) worse.

By all means seperate out packet_*, that would be a bonus. (And if you 
can stop the makefile building the plugins and documentation every time 
that would be great.)

-- 
Richard Urwin