ANNOUNCEMENT: Live Wireshark University & Allegro Packets online APAC Wireshark Training Session
July 17th, 2024 | 10:00am-11:55am SGT (UTC+8) | Online

Ethereal-dev: Re: [Ethereal-dev] patch Frame Relay dissector to dissect GPRS Network Service p

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Guy Harris <guy@xxxxxxxxxxxx>
Date: Tue, 2 Sep 2003 14:02:11 -0700

On Thursday, August 28, 2003, at 5:02 AM, jkor@xxxxxxxx wrote:

I am sending patch for packet-fr.c file to support
decoding "Network Service" defined in ETSI 8.16
specification for GPRS Gb line. Patch is made to
nightly snapshot
from 2003-08-27. The patch also solve the
unpossibility to filter on bigger DLCI than 16.

Bigger than 16 (i.e., bigger than 4 bits), or bigger than 16 bits (i.e., 3-octet or 4-octet address)? If "bigger than 16", are you saying that having fr.dlci being a bitfield doesn't work when you try to filter on it?

In any case, I've checked in a change to handle 3-octet and 4-octet addresses; it also puts the DLCI field in not as a bitfield but as a regular field, as it dissects each octet separately, and assembles the DLCI from the pieces of it.

Patch adds protocol preference which choose mode
of protocol encapsulation next layers.

So is the GPRS Network Service just another form of Frame Relay payload? If so, then nothing needs to change in the dissector to handle it other than the code to handle the payload - none of the stuff to process the address field, or the columns, needs to change.

Also, if it's a protocol running atop Frame Relay, it should be treated as such - given its own "packet-XXX.c" file, and its own protocol tree, and its own column settings, and the like.