Wireshark · Ethereal-dev: Re: [Ethereal-dev] hanging graphs

[Pavel Mores <pvl@xxxxx>]

On Wed, Dec 18, 2002 at 03:18:44PM -0800, Guy Harris wrote:

> On Wed, Dec 18, 2002 at 11:40:37PM +0100, Martin Regner wrote:
> > I noticed that the time stamps are incorrect for certain frames,
> > resulting in negative time differences between packets.
> 
> That's what I suspected the problem would be.
> 
> I've checked in a change to "gtk/tcp_graph.c" not to assume that the
> time stamp of the last frame is the largest time stamp in the packet;
> instead, the loop that computes the maximum Y-axis value now also
> computes the largest time stamp.

Thanks.

> > I guess that even if the hanging problem is solved you will get very
> > strange results for the TCP analysis if you don't get rid of the
> > timestamp problem.
> 
> ...the effect of the change will probably be to replace a hang with a
> not-entirely-sensible graph.

Well, if the change doesn't break handling of correct captures (which it
shouldn't, according to your description of the change) then I guess it
should be OK.  Getting a not-entirely-sensible graph for a
not-entirely-sensible capture seems reasonable to me. ;-)

	pvl