Wireshark · Ethereal-dev: Re: [Ethereal-dev] packet-stat.c

[Guy Harris <gharris@xxxxxxxxxxxx>]

On Fri, Mar 16, 2001 at 05:11:14PM +1100, Ronnie Sahlberg wrote:
> Does this mean that all  "if(tree){"
> surrounding other proto_add_item()  can be removed?

It means they can be removed; whether they *should* be removed is
another matter.  There *might* be a slight performance improvement from
not making the procedure call if "tree" is null; on the other hand,
there might be a slight performance improvement from making various
routines that call "proto_tree_add_item()" smaller.

> if so, I can produce a set of patches that removes the "if(tree){"
> from the packet-*.c files.

I wouldn't bother going through all the "packet-*.c" files removing
them; however, if you've added some, go ahead and remove them.