Wireshark · Wireshark-users: [Wireshark-users] netscaler.c build failures

[jungle boogie <jungleboogie0@xxxxxxxxx>]

Hello All,

It's been a little while since I built wireshark from source on Ubuntu 
but when I try, it's failing:


I happen to see the wiretap source was recently updated:
https://github.com/wireshark/wireshark/blame/master/wiretap/netscaler.c

make[2]: Entering directory '/home/user/bin/wireshark/wiretap'
make  all-am
make[3]: Entering directory '/home/user/bin/wireshark/wiretap'
  CC       5views.lo
  CC       aethra.lo
  CC       ascendtext.lo
  CC       atm.lo
  CC       ber.lo
  CC       btsnoop.lo
  CC       camins.lo
  CC       capsa.lo
  CC       catapult_dct2000.lo
  CC       commview.lo
  CC       cosine.lo
  CC       csids.lo
  CC       daintree-sna.lo
  CC       dbs-etherwatch.lo
  CC       dct3trace.lo
  CC       erf.lo
  CC       eyesdn.lo
  CC       file_access.lo
  CC       file_wrappers.lo
  CC       hcidump.lo
  CC       i4btrace.lo
  CC       ipfix.lo
  CC       iptrace.lo
  CC       iseries.lo
  CC       mime_file.lo
  CC       json.lo
  CC       k12.lo
  CC       lanalyzer.lo
  CC       logcat_text.lo
  CC       logcat.lo
  CC       libpcap.lo
  CC       merge.lo
  CC       mpeg.lo
  CC       mplog.lo
  CC       mp2t.lo
  CC       netmon.lo
  CC       netscaler.lo
netscaler.c: In function 'nstrace_read_v20':
netscaler.c:1155:56: error: comparison between signed and unsigned 
integer expressions [-Werror=sign-compare]
         if (nspr_getv20recordsize((nspr_hd_v20_t *)fp) < sizeof *fp) {\
                                                        ^
netscaler.c:1203:13: note: in expansion of macro 'PACKET_DESCRIBE'

PACKET_DESCRIBE(phdr,FULL,ver,v##ver##_full,fp,pktracefull_v##ver,HEADERVER);
             ^
netscaler.c:1225:17: note: in expansion of macro 'GENERATE_CASE_FULL'
                 GENERATE_CASE_FULL(&wth->phdr,20,200);
                 ^
netscaler.c:1155:56: error: comparison between signed and unsigned 
integer expressions [-Werror=sign-compare]
         if (nspr_getv20recordsize((nspr_hd_v20_t *)fp) < sizeof *fp) {\
                                                        ^
netscaler.c:1216:13: note: in expansion of macro 'PACKET_DESCRIBE'

PACKET_DESCRIBE(phdr,PART,ver,v##ver##_part,pp,pktracepart_v##ver,HEADERVER);
             ^
netscaler.c:1226:17: note: in expansion of macro 'GENERATE_CASE_PART'
                 GENERATE_CASE_PART(&wth->phdr,20,200);
                 ^
netscaler.c:1155:56: error: comparison between signed and unsigned 
integer expressions [-Werror=sign-compare]
         if (nspr_getv20recordsize((nspr_hd_v20_t *)fp) < sizeof *fp) {\
                                                        ^
netscaler.c:1203:13: note: in expansion of macro 'PACKET_DESCRIBE'

PACKET_DESCRIBE(phdr,FULL,ver,v##ver##_full,fp,pktracefull_v##ver,HEADERVER);
             ^
netscaler.c:1227:17: note: in expansion of macro 'GENERATE_CASE_FULL'
                 GENERATE_CASE_FULL(&wth->phdr,21,201);
                 ^
netscaler.c:1155:56: error: comparison between signed and unsigned 
integer expressions [-Werror=sign-compare]
         if (nspr_getv20recordsize((nspr_hd_v20_t *)fp) < sizeof *fp) {\
                                                        ^
netscaler.c:1216:13: note: in expansion of macro 'PACKET_DESCRIBE'

PACKET_DESCRIBE(phdr,PART,ver,v##ver##_part,pp,pktracepart_v##ver,HEADERVER);
             ^
netscaler.c:1228:17: note: in expansion of macro 'GENERATE_CASE_PART'
                 GENERATE_CASE_PART(&wth->phdr,21,201);
                 ^
netscaler.c:1155:56: error: comparison between signed and unsigned 
integer expressions [-Werror=sign-compare]
         if (nspr_getv20recordsize((nspr_hd_v20_t *)fp) < sizeof *fp) {\
                                                        ^
netscaler.c:1203:13: note: in expansion of macro 'PACKET_DESCRIBE'

PACKET_DESCRIBE(phdr,FULL,ver,v##ver##_full,fp,pktracefull_v##ver,HEADERVER);
             ^
netscaler.c:1229:17: note: in expansion of macro 'GENERATE_CASE_FULL'
                 GENERATE_CASE_FULL(&wth->phdr,22,202);
                 ^
netscaler.c:1155:56: error: comparison between signed and unsigned 
integer expressions [-Werror=sign-compare]
         if (nspr_getv20recordsize((nspr_hd_v20_t *)fp) < sizeof *fp) {\
                                                        ^
netscaler.c:1216:13: note: in expansion of macro 'PACKET_DESCRIBE'

PACKET_DESCRIBE(phdr,PART,ver,v##ver##_part,pp,pktracepart_v##ver,HEADERVER);
             ^
netscaler.c:1230:17: note: in expansion of macro 'GENERATE_CASE_PART'
                 GENERATE_CASE_PART(&wth->phdr,22,202);
                 ^
netscaler.c:1155:56: error: comparison between signed and unsigned 
integer expressions [-Werror=sign-compare]
         if (nspr_getv20recordsize((nspr_hd_v20_t *)fp) < sizeof *fp) {\
                                                        ^
netscaler.c:1203:13: note: in expansion of macro 'PACKET_DESCRIBE'

PACKET_DESCRIBE(phdr,FULL,ver,v##ver##_full,fp,pktracefull_v##ver,HEADERVER);
             ^
netscaler.c:1231:17: note: in expansion of macro 'GENERATE_CASE_FULL'
                 GENERATE_CASE_FULL(&wth->phdr,23,203);
                 ^
netscaler.c:1155:56: error: comparison between signed and unsigned 
integer expressions [-Werror=sign-compare]
         if (nspr_getv20recordsize((nspr_hd_v20_t *)fp) < sizeof *fp) {\
                                                        ^
netscaler.c:1216:13: note: in expansion of macro 'PACKET_DESCRIBE'

PACKET_DESCRIBE(phdr,PART,ver,v##ver##_part,pp,pktracepart_v##ver,HEADERVER);
             ^
netscaler.c:1232:17: note: in expansion of macro 'GENERATE_CASE_PART'
                 GENERATE_CASE_PART(&wth->phdr,23,203);
                 ^
netscaler.c:1155:56: error: comparison between signed and unsigned 
integer expressions [-Werror=sign-compare]
         if (nspr_getv20recordsize((nspr_hd_v20_t *)fp) < sizeof *fp) {\
                                                        ^
netscaler.c:1210:13: note: in expansion of macro 'PACKET_DESCRIBE'

PACKET_DESCRIBE(phdr,FULL,ver,v##ver##_full,fp,pktracefull_v##ver,HEADERVER);
             ^
netscaler.c:1233:17: note: in expansion of macro 'GENERATE_CASE_FULL_V25'
                 GENERATE_CASE_FULL_V25(&wth->phdr,24,204);
                 ^
netscaler.c:1155:56: error: comparison between signed and unsigned 
integer expressions [-Werror=sign-compare]
         if (nspr_getv20recordsize((nspr_hd_v20_t *)fp) < sizeof *fp) {\
                                                        ^
netscaler.c:1223:13: note: in expansion of macro 'PACKET_DESCRIBE'

PACKET_DESCRIBE(phdr,PART,ver,v##ver##_part,pp,pktracepart_v##ver,HEADERVER);
             ^
netscaler.c:1234:17: note: in expansion of macro 'GENERATE_CASE_PART_V25'
                 GENERATE_CASE_PART_V25(&wth->phdr,24,204);
                 ^
netscaler.c:1155:56: error: comparison between signed and unsigned 
integer expressions [-Werror=sign-compare]
         if (nspr_getv20recordsize((nspr_hd_v20_t *)fp) < sizeof *fp) {\
                                                        ^
netscaler.c:1210:13: note: in expansion of macro 'PACKET_DESCRIBE'

PACKET_DESCRIBE(phdr,FULL,ver,v##ver##_full,fp,pktracefull_v##ver,HEADERVER);
             ^
netscaler.c:1235:17: note: in expansion of macro 'GENERATE_CASE_FULL_V25'
                 GENERATE_CASE_FULL_V25(&wth->phdr,25,205);
                 ^
netscaler.c:1155:56: error: comparison between signed and unsigned 
integer expressions [-Werror=sign-compare]
         if (nspr_getv20recordsize((nspr_hd_v20_t *)fp) < sizeof *fp) {\
                                                        ^
netscaler.c:1223:13: note: in expansion of macro 'PACKET_DESCRIBE'

PACKET_DESCRIBE(phdr,PART,ver,v##ver##_part,pp,pktracepart_v##ver,HEADERVER);
             ^
netscaler.c:1236:17: note: in expansion of macro 'GENERATE_CASE_PART_V25'
                 GENERATE_CASE_PART_V25(&wth->phdr,25,205);
                 ^
netscaler.c:1155:56: error: comparison between signed and unsigned 
integer expressions [-Werror=sign-compare]
         if (nspr_getv20recordsize((nspr_hd_v20_t *)fp) < sizeof *fp) {\
                                                        ^
netscaler.c:1210:13: note: in expansion of macro 'PACKET_DESCRIBE'

PACKET_DESCRIBE(phdr,FULL,ver,v##ver##_full,fp,pktracefull_v##ver,HEADERVER);
             ^
netscaler.c:1237:17: note: in expansion of macro 'GENERATE_CASE_FULL_V25'
                 GENERATE_CASE_FULL_V25(&wth->phdr,26,206);
                 ^
netscaler.c:1155:56: error: comparison between signed and unsigned 
integer expressions [-Werror=sign-compare]
         if (nspr_getv20recordsize((nspr_hd_v20_t *)fp) < sizeof *fp) {\
                                                        ^
netscaler.c:1223:13: note: in expansion of macro 'PACKET_DESCRIBE'

PACKET_DESCRIBE(phdr,PART,ver,v##ver##_part,pp,pktracepart_v##ver,HEADERVER);
             ^
netscaler.c:1238:17: note: in expansion of macro 'GENERATE_CASE_PART_V25'
                 GENERATE_CASE_PART_V25(&wth->phdr,26,206);
                 ^
cc1: all warnings being treated as errors
Makefile:994: recipe for target 'netscaler.lo' failed
make[3]: *** [netscaler.lo] Error 1
make[3]: Leaving directory '/home/user/bin/wireshark/wiretap'
Makefile:820: recipe for target 'all' failed
make[2]: *** [all] Error 2
make[2]: Leaving directory '/home/user/bin/wireshark/wiretap'
Makefile:3620: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/home/user/bin/wireshark'
Makefile:1780: recipe for target 'all' failed
make: *** [all] Error 2


Thanks for any pointers!