Wireshark-dev: Re: [Wireshark-dev] clang-tools on Windows source code
From: Gerald Combs <[email protected]>
Date: Fri, 11 Dec 2020 13:36:32 -0800
On 12/11/20 3:47 AM, Jaap Keuter wrote:
> Hi,
> 
> When changing Win32 code the jobs run for master and release-3.4 borked on this:
> 
> 4882$ sh -c '[ ! -e ../tools/validate-clang-check.sh ] || ../tools/validate-clang-check.sh'
> 4883/builds/wireshark/wireshark/build/../ui/win32/file_dlg_win32.c:13:10: fatal error: 'tchar.h' file not found
> 4884#include <tchar.h>
> 4885         ^~~~~~~~~
> 48861 error generated.
> 4887Error while processing /builds/wireshark/wireshark/build/../ui/win32/file_dlg_win32.c.
> 4888/builds/wireshark/wireshark/build/../ui/win32/file_dlg_win32.c:13:10: fatal error: 'tchar.h' file not found
> 4889#include <tchar.h>
> 4890         ^~~~~~~~~
> 48911 error generated.
> 4892Error while processing /builds/wireshark/wireshark/build/../ui/win32/file_dlg_win32.c.
> 
> (see pipeline https://gitlab.com/wireshark/wireshark/-/pipelines/228408750)
> 
> Curiously enough the job for master-3.2 succeeded?
> 
> 5176Built using clang Ubuntu Clang 10.0.1 .
> 5177$ sh -c '[ ! -e ../tools/validate-clang-check.sh ] || ../tools/validate-clang-check.sh'
> 5178$ ninja checkAPI
> 5179[1/34] Running checkAPI_caputils-todo
> 
> (see pipeline https://gitlab.com/wireshark/wireshark/-/pipelines/228409358)
> 
> What’s the difference here? Both seem to be using the same script and clang-tools.

validate-clang-check.sh doesn't exist in master-3.2. It started out as validate-clang-check.py, but was migrated to a shell script in master in August in b586f2578. We should probably cherry-pick that to 3.2 and add "#ifdef _WIN32" guards to file_dlg_win32.c to match console_win32.c.