Wireshark · Wireshark-dev: Re: [Wireshark-dev] Speex for Windows?

[Pascal Quantin <pascal@xxxxxxxxxxxxx>]

Le lun. 8 juil. 2019 à 18:47, Maynard, Chris via Wireshark-dev <wireshark-dev@xxxxxxxxxxxxx> a écrit :

OK, thanks.

 

But then why is it reporting that an optional package hasn’t been found if this package isn’t even needed?  It implies that there’s some feature that’s not being built with Wireshark, does it not?

As you can see in the about dialog on Windows you used the builtin version instead of a shared library provided by the system. That's all. João did this change to favor a Speex version provided by the system over our copied version (see https://code.wireshark.org/review/31857).

 

- Chris

 

From: Pascal Quantin [mailto:pascal@xxxxxxxxxxxxx]
Sent: Monday, July 8, 2019 12:37 PM
To: Developer support list for Wireshark <wireshark-dev@xxxxxxxxxxxxx>
Cc: Maynard, Chris <Christopher.Maynard@xxxxxxx>
Subject: Re: [Wireshark-dev] Speex for Windows?

 

Hi Chris,

 

Le lun. 8 juil. 2019 à 18:35, Maynard, Chris via Wireshark-dev <wireshark-dev@xxxxxxxxxxxxx> a écrit :

When compiling master (v3.1.0rc0-1232-gd8ad7a686384) on Windows, I noticed:

 

-- Could NOT find SpeexDSP (missing:  SPEEXDSP_LIBRARY SPEEXDSP_INCLUDE_DIR)

…

-- The following OPTIONAL packages have not been found:

 

* SpeexDSP , SpeexDSP is a patent-free, Open Source/Free Software DSP library , <https://www.speex.org/>

   RTP audio resampling

 

It seems that the buildbots don’t have SpeexDSP installed either.  Also, there’s no mention of Speex in the Developer’s Guide: https://www.wireshark.org/docs/wsdg_html_chunked/ChSetupWin32.html, so does this mean it’s not yet supported on Windows?  If it would be possible to use this on Windows, then in addition to a Developer Guide update, it seems like Speex packages should be included in https://anonsvn.wireshark.org/wireshark-win32-libs/trunk/packages/ and https://anonsvn.wireshark.org/wireshark-win64-libs/trunk/packages/.

 

Of course https://www.speex.org/ mentions the following:

 

—The Speex codec has been obsoleted by Opus. It will continue to be available, but since Opus is better than Speex in all aspects, users are encouraged to switch—

 

So wouldn’t Opus be the way to go instead of Speex?

 

The only part of Speex we are using so far is the resampler and not the codec if I'm not mistaken. On Windows we use the internal Speex resampler and not the system wide version. So nothing to worry about :)

 

BR,

Pascal.

 

 

 

 

 

 

 

 

 

 

 

CONFIDENTIALITY NOTICE: This message is the property of International Game Technology PLC and/or its subsidiaries and may contain proprietary, confidential or trade secret information. This message is intended solely for the use of the addressee. If you are not the intended recipient and have received this message in error, please delete this message from your system. Any unauthorized reading, distribution, copying, or other use of this message or its attachments is strictly prohibited.

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe