Wireshark-dev: Re: [Wireshark-dev] Wireshark 3.0.1 build warning on Windows
From: "Maynard, Chris" <[email protected]>
Date: Wed, 10 Apr 2019 22:20:19 +0000
> -----Original Message-----
> From: Wireshark-dev [mailto:[email protected]] On
> Behalf Of Guy Harris
> Sent: Wednesday, April 10, 2019 5:35 PM
> To: Developer support list for Wireshark <[email protected]>
> Subject: Re: [Wireshark-dev] Wireshark 3.0.1 build warning on Windows
>
> Check out
>
>         https://buildbot.wireshark.org/wireshark-
> 3.0/builders/Windows%20Server%202016%20x86/builds/177/steps/compile_1/l
> ogs/warnings%20%281%29
>
> and all the builds back to 2019-04-01 - they all have the warning.

OK, I'm not sure how you were able to navigate your way to that page, but I'm glad you found it so I know the warning wasn't just with my environment.

I usually start at https://buildbot.wireshark.org/wireshark-master/waterfall and navigate my way from there.  So, for example, I when looking for warnings, I might navigate along this path for a somewhat recent build:
https://buildbot.wireshark.org/wireshark-master/builders/Windows%20Server%202016%20x86
https://buildbot.wireshark.org/wireshark-master/builders/Windows%20Server%202016%20x86/builds/5118
https://buildbot.wireshark.org/wireshark-master/builders/Windows%20Server%202016%20x86/builds/5118/steps/compile_1

... but here the warnings are shown as 0, and there's nothing in the stdio log to indicate any warnings either, although I suspect this is intentional if warnings are being redirected elsewhere (stderr or a separate warnings file).

> Is it intentional that we're not building with the "fail on warnings" flag on the
> 3.0 Windows buildbot?

Good question.  I think it is, but maybe for a very old reason that nobody can remember?

> > Note that I only get this warning when compiling for 32-bit on a 64-bit
> Windows host:
>
> On 64-bit UN*Xes (LP64) and Windows (LLP64), size_t is 64-bit, so all non-
> negative gint64 values fit in a size_t.  The only 32-bit build we're doing is the
> 32-bit Windows build.
>
> This is fixed by
>
>         https://code.wireshark.org/review/31901
>
> which I'll look at backporting.

Great, thanks!
- Chris











CONFIDENTIALITY NOTICE: This message is the property of International Game Technology PLC and/or its subsidiaries and may contain proprietary, confidential or trade secret information. This message is intended solely for the use of the addressee. If you are not the intended recipient and have received this message in error, please delete this message from your system. Any unauthorized reading, distribution, copying, or other use of this message or its attachments is strictly prohibited.