Wireshark-dev: Re: [Wireshark-dev] More Lua tests needed
From: Alexis La Goutte <[email protected]>
Date: Wed, 17 Oct 2018 09:01:15 +0200
Hi Richard,

May be a good idea to open a issue on bugtracker for don't forget...

On Wed, Oct 17, 2018 at 12:00 AM Richard Sharpe <[email protected]> wrote:
Hi folks,

During testing of my changes to add support for Range Strings to the
Lua support I found that there was a serious bug in the support for
value strings.

It was trying to ensure that the value passed in was a string, but the
function lua_isstring will return true for strings and integers. You
need to test the lua_ttype of the thing you are looking at.

This means that we need better tests in tests/lua/tvb.lua.

I have added a really simple test to ensure that range strings and
value strings are parsed if they are correct but have not added
anything to test for non-strings, and too many values, etc.

Hopefully, someone with more knowledge of the Lua tests can do that.

Richard Sharpe
Sent via:    Wireshark-dev mailing list <[email protected]>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:[email protected]?subject=unsubscribe