Wireshark · Wireshark-dev: Re: [Wireshark-dev] Cannot push patch to Gerrit - Found WIP commit

[Vasil Velichkov <vvvelichkov@xxxxxxxxx>]

Hi Andrii,

Most probably you have activated the pre-push hook and your commit message starts with WIP

$ grep WIP .git/hooks/ -R
.git/hooks/pre-push.sample:# with "WIP" (work in progress).
.git/hooks/pre-push.sample:        # Check for WIP commit
.git/hooks/pre-push.sample:        commit=`git rev-list -n 1 --grep '^WIP' "$range"`
.git/hooks/pre-push.sample:            echo >&2 "Found WIP commit in $local_ref, not pushing"

You need to enable the Wireshark's pre-commit hook and probably you don't need this pre-push hook. See https://wiki.wireshark.org/Development/SubmittingPatches#Git_Hooks

On 09/05/2018 03:21 AM, Andrii Vladyka wrote:

I am trying to push a patch (single commit on top of the latest master branch) with the following syntax:

git push ssh://username@xxxxxxxxxxxxxxxxxx:29418/wireshark HEAD:refs/for/master

I get the following error all the time:

Found WIP commit in f84749a, not pushing

error: failed to push some refs to 'ssh://username@xxxxxxxxxxxxxxxxxx:29418/wireshark'

Any ideas on what I am doing wrong?

Regards,
Andrii Vladyka

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe